Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build link-checking for book #77

Closed
skade opened this issue Aug 18, 2019 · 2 comments
Closed

Build link-checking for book #77

skade opened this issue Aug 18, 2019 · 2 comments
Labels
documentation Improvements or additions to documentation duplicate This issue or pull request already exists

Comments

@skade
Copy link
Collaborator

skade commented Aug 18, 2019

Land #61 and make sure it doesn't break netlify ;).

  • Turn book building into a script
  • Make sure link checking only triggers during testing
  • On deploy environments, download the mdbook and linkcheck binary
@skade skade mentioned this issue Aug 26, 2019
Closed
@yoshuawuyts yoshuawuyts added the documentation Improvements or additions to documentation label Sep 18, 2019
@yoshuawuyts
Copy link
Contributor

@skade can this be closed?

@yoshuawuyts
Copy link
Contributor

Ah, actually going to close this as a duplicate of #82 -- even though it's filed later it seems to still be active.

@yoshuawuyts yoshuawuyts added the duplicate This issue or pull request already exists label Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skade @yoshuawuyts