Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression with v1 #575

Open
zkat opened this issue Nov 21, 2019 · 0 comments
Open

Performance regression with v1 #575

zkat opened this issue Nov 21, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@zkat
Copy link

zkat commented Nov 21, 2019

Heya. I noticed a significant (~2x) perf regression after upgrading to v1 recently. I also tested against 1.1.0 and didn't see a difference. The regression happens when doing filesystem reads (though it may happen in other situations -- I'm only sharing what my own benchmarks do).

Repro

  1. git clone https://github.com/zkat/cacache-rs --branch async-std-regression
  2. cd cacache-rs
  3. cargo bench
  4. git checkout head~1
  5. cargo bench

Details

You can see the benchmarks themselves over at https://github.com/zkat/cacache-rs/blob/async-std-regression/benches/benchmarks.rs#L44-L74

@yoshuawuyts yoshuawuyts added the bug Something isn't working label Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants