-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "runtime" feature flag? #438
Comments
@stjepang I like this idea a lot, and think that we should do it. I don't think we need to add a "core" feature flag, because "core" is what you're left with if you disable "runtime". Besides: it wouldn't make sense to every enable "runtime", but not "core", so I'm not sure this would even make sense. |
Also I've been thinking of moving #238 forward, and it'd be interesting to consider what to name that feature. It'd be off-by-default, but would be a superset of "runtime". |
Maybe |
@stjepang oh I like that! |
If the The reason for that was discussed in #417, where we decided that if So if someone wanted to use "core" parts of [dependencies]
async-std = { version = "1", default-features = false, features = ["core"] } But perhaps "core" is not the best name for what we want here. We might want to reserve that name for parts of |
@stjepang I think we should not have another feature flag, and instead let the absence of "runtime" imply "core". If you want neither, it's probably time to remove async-std from the dep tree. I think that would create a nice hierarchy, and a friendly user interface! |
@yoshuawuyts I agree with you, but there's a compatibility hazard in that if we make something available by specifying So perhaps, just in case, we should introduce flag I know @jamesmunns has liked this idea. In particular, we should consider making |
@stjepang okay sure, let's put it under |
Some people want to use
async-std
for its channels, streams, and such without pulling in the actual runtime (networking driver and executor).Perhaps we should consider introducing
runtime
feature flag, which would be enabled by default and would enable modulesfs
,net
,os
,process
, andtask
modules.We should then also pick a name for the core parts of
async-std
, perhaps we could have them behind a newcore
feature flag?The text was updated successfully, but these errors were encountered: