New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass through AsyncBufRead #2

Open

yoshuawuyts opened this issue Dec 19, 2019 · 2 comments

Contributor

yoshuawuyts commented Dec 19, 2019

If AsyncBufRead is implemented on T, the stream should expose it. This makes some implementations much more efficient. Thanks!

The text was updated successfully, but these errors were encountered:

Member

dignifiedquire commented Dec 20, 2019 •

edited

Loading

To make this work we need to BufRead to native-tls::TlsStream

for that we need

SecureTransport: start here: https://github.com/kornelski/rust-security-framework/blob/master/security-framework/src/secure_transport.rs#L1069
openssl: start here: https://github.com/sfackler/rust-openssl/blob/master/openssl/src/ssl/mod.rs#L3547
SChannel: already done: https://github.com/steffengy/schannel-rs/blob/master/src/tls_stream.rs#L918
native-tls: start here: https://github.com/sfackler/rust-native-tls/blob/master/src/imp/security_framework.rs#L477

Contributor Author

yoshuawuyts commented Dec 20, 2019

Note that we may also need to forward Read for &T and BufRead for &T. Need to verify if we need this tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment