Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing error behavior if margin generation results in empty catalog #258

Open
3 tasks done
delucchi-cmu opened this issue Mar 18, 2024 · 0 comments
Open
3 tasks done
Assignees
Labels
bug Something isn't working

Comments

@delucchi-cmu
Copy link
Contributor

Bug report

If you set a margin that is too low to result in any objects falling in the margins, the pipeline fails on the parquet_metadata.write_parquet_metadata call with varying error messages, depending on your file system.

On a local filesystem:

pyarrow.lib.ArrowInvalid: ParquetDatasetFactory must contain a schema with at least one column

For azure:

FileNotFoundError: abfs://hipscat/pytests/data/small_sky_order1_margin

If there are no points found in the first mapping step, then we should error out of the pipeline early, stating that no margin objects were found and they should increase the margin.

Before submitting
Please check the following:

  • I have described the situation in which the bug arose, including what code was executed, information about my environment, and any applicable data others will need to reproduce the problem.
  • I have included available evidence of the unexpected behavior (including error messages, screenshots, and/or plots) as well as a descriprion of what I expected instead.
  • If I have a solution in mind, I have provided an explanation and/or pseudocode and/or task list.
@delucchi-cmu delucchi-cmu added the bug Something isn't working label Mar 18, 2024
@delucchi-cmu delucchi-cmu self-assigned this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant