Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hipscat.inspection takes lsdb.Catalog #227

Closed
nevencaplar opened this issue Feb 29, 2024 · 1 comment · Fixed by astronomy-commons/lsdb#229
Closed

hipscat.inspection takes lsdb.Catalog #227

nevencaplar opened this issue Feb 29, 2024 · 1 comment · Fixed by astronomy-commons/lsdb#229
Assignees

Comments

@nevencaplar
Copy link
Member

Plotting functionality in hipscat.inspection expects the input to be a hipscat.Catalog, and it fails with non-trivial error messages when trying to pass lsdb.Catalog. At the moment, a user needs to know to invoke .hc_structure on their lsdb.Catalog and pass that to the plotting function.

Make it possible for a user to pass lsdb.Catalog to hipscat.inspection in order to plot the results.

@delucchi-cmu
Copy link
Contributor

Alternatively, we could create a method on lsdb.Catalog like plot_pixels which calls the inspection method, passing in the hc_structure. This may be more intuitive for users, and avoids circular dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants