Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Pixel Tree #225

Closed
smcguire-cmu opened this issue Feb 28, 2024 · 0 comments · Fixed by #249
Closed

Optimize Pixel Tree #225

smcguire-cmu opened this issue Feb 28, 2024 · 0 comments · Fixed by #249
Assignees
Labels
enhancement New feature or request

Comments

@smcguire-cmu
Copy link
Contributor

Currently, the pixel tree uses individual python objects for its nodes. For larger trees, this means it performs pretty slowly. By changing the tree structure to instead use a simpler object like a tuple, this could improve performance. This would mean a slight change to the pixel tree interface, but given that most of our interactions with the tree come from performing a pixel alignment and working with that, I don't think this will require big changes across the code base.

Alternatively, the tree could be written in something like C or Rust and wrapped for the best performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant