Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enable execution mode for AWS ECS tasks #1355

Closed
1 task done
romina-nikolova opened this issue Nov 29, 2024 · 5 comments · Fixed by #1507
Closed
1 task done

[Feature] Enable execution mode for AWS ECS tasks #1355

romina-nikolova opened this issue Nov 29, 2024 · 5 comments · Fixed by #1507
Labels
area:execution Related to the execution environment/mode, like Docker, Kubernetes, Local, VirtualEnv, etc enhancement New feature or request triage-needed Items need to be reviewed / assigned to milestone

Comments

@romina-nikolova
Copy link

romina-nikolova commented Nov 29, 2024

Description

Similarly to the Azure Container Instance execution mode, it would be super useful to have an AWS ECS execution mode supported! Alternatively, could a different mode be used to run ECS tasks?

Use case/motivation

Enrich scope of Cosmos

Related issues

(#635)

Are you willing to submit a PR?

  • Yes, I am willing to submit a PR!
@romina-nikolova romina-nikolova added enhancement New feature or request triage-needed Items need to be reviewed / assigned to milestone labels Nov 29, 2024
@dosubot dosubot bot added the area:execution Related to the execution environment/mode, like Docker, Kubernetes, Local, VirtualEnv, etc label Nov 29, 2024
@tatiana
Copy link
Collaborator

tatiana commented Dec 27, 2024

@romina-nikolova, we would gladly receive a contribution in this area; thanks for suggesting it!

@nicor88
Copy link

nicor88 commented Jan 25, 2025

@tatiana I might be interested to contribute to this feature.

Do you have any guidelines to start with?

@aoelvp94
Copy link
Contributor

aoelvp94 commented Jan 28, 2025

@tatiana I might be interested to contribute to this feature.

Do you have any guidelines to start with?

Some of my workmates were working on this https://github.com/MuttData/astronomer-cosmos/tree/feat/aws-ecs-task-run-execution-mode/ in case you want to take that development. Tests and docs would be great to have for having this feature completely. WDYT @tatiana @nicor88 ?

@tatiana
Copy link
Collaborator

tatiana commented Jan 28, 2025

This is looking great, @aoelvp94 ! Please, could you create a PR with these changes?

I agree we'd need tests and docs. Is this something your team would have the capacity or would you need help?

@nicor88 our contribution guidelines:
https://github.com/astronomer/astronomer-cosmos/blob/main/docs/contributing.rst

And some examples of similar PRs:

We're aiming to release Cosmos 1.9 on the 14th of February - we may be able to add this with your help.

@aoelvp94
Copy link
Contributor

This is looking great, @aoelvp94 ! Please, could you create a PR with these changes?

I agree we'd need tests and docs. Is this something your team would have the capacity or would you need help?

@nicor88 our contribution guidelines: https://github.com/astronomer/astronomer-cosmos/blob/main/docs/contributing.rst

And some examples of similar PRs:

We're aiming to release Cosmos 1.9 on the 14th of February - we may be able to add this with your help.

We are testing the feature on ECS just to make sure it works. We want to have the PR with the feature already tested on ECS and the pending stuff like docs and tests for next week :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:execution Related to the execution environment/mode, like Docker, Kubernetes, Local, VirtualEnv, etc enhancement New feature or request triage-needed Items need to be reviewed / assigned to milestone
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants