Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the manifest.json #1407

Open
pankajastro opened this issue Dec 18, 2024 · 0 comments
Open

Unify the manifest.json #1407

pankajastro opened this issue Dec 18, 2024 · 0 comments
Labels
parsing:dbt_manifest Issues, questions, or features related to dbt_manifest parsing

Comments

@pankajastro
Copy link
Contributor

pankajastro commented Dec 18, 2024

Currently, we have checked in manifest.json at multiple places example

https://github.com/astronomer/astronomer-cosmos/blob/main/tests/sample/manifest_source.json
https://github.com/astronomer/astronomer-cosmos/blob/main/dev/dags/dbt/jaffle_shop/target/manifest.json

As a result, many times, both files diverge and result in unexpected results during the test.

For example, we have test https://github.com/astronomer/astronomer-cosmos/blob/0edb07d6b58827ebf66fbc82a062ea0a5cfb0717/tests/dbt/test_graph.py#L614 which run for dbt ls and manifest and in both cases it uses different manifest file and it results in unexpected failure because manifest_source.json is not latest.

@dosubot dosubot bot added the parsing:dbt_manifest Issues, questions, or features related to dbt_manifest parsing label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsing:dbt_manifest Issues, questions, or features related to dbt_manifest parsing
Projects
None yet
Development

No branches or pull requests

1 participant