Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need the bumpversion workflow? #42

Open
fkiraly opened this issue Jan 19, 2024 · 2 comments
Open

Do we need the bumpversion workflow? #42

fkiraly opened this issue Jan 19, 2024 · 2 comments

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Jan 19, 2024

The bumpversion workflow runs poetry bumpversion upon mege to main.

That seems too often, usually on bumps once per release only, and there are typically more locations to update (docs, readme) than just the package version attribute.

Not sure what the intended workflow is here, I have not seen this before - explanations would be appreciated, @astrogilda.
@fkiraly
Copy link
Collaborator Author

fkiraly commented Jan 19, 2024

... and it keeps failing:

image

@fkiraly fkiraly mentioned this issue Feb 4, 2024
Merged
fkiraly added a commit that referenced this issue Feb 4, 2024
@fkiraly
maint: remove trigger for bumpversion.yml CI element (#55)
6165ada 
Removes the trigger (merge to `main`) for the `bumpversion` CI element,
but does not remove it.

Temporarily addresses
#42, at least the
constant failures, until discussion completes.
@fkiraly
Copy link
Collaborator Author

fkiraly commented Feb 4, 2024

I've temporarily removed the trigger, due to the CI element always failing.

We can re-enable it, of course it needs to run for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fkiraly