You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #1643 removes fragile tests that were internal to the composer crate as they were a maintenance burden.
The tests that are removed:
full_bundle - This is covered by the unit tests in the bundle_factory module internal to the composer. Probably doesn't require adding a new black box test.
bundle_triggered_by_block_timer - This test assumes quite a bit of knowledge about the internal functions of the composer (specifically that if the bundle isn't filled then it will be submitted after the block timer).
two_seq_actions_single_bundle - A test similar to the existing single_rollup_tx_payload_integrity that has two transactions should be added to cover this.
chain_id_mismatch_returns_error - Likely requires bubbling errors up and out from the composer service.
┆Issue Number: ENG-914
The text was updated successfully, but these errors were encountered:
PR #1643 removes fragile tests that were internal to the
composer
crate as they were a maintenance burden.The tests that are removed:
full_bundle
- This is covered by the unit tests in thebundle_factory
module internal to thecomposer
. Probably doesn't require adding a new black box test.bundle_triggered_by_block_timer
- This test assumes quite a bit of knowledge about the internal functions of the composer (specifically that if the bundle isn't filled then it will be submitted after the block timer).two_seq_actions_single_bundle
- A test similar to the existing single_rollup_tx_payload_integrity that has two transactions should be added to cover this.chain_id_mismatch_returns_error
- Likely requires bubbling errors up and out from the composer service.┆Issue Number: ENG-914
The text was updated successfully, but these errors were encountered: