Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto: remove optimistic block generated proto files #1823

Open
bharath-123 opened this issue Nov 19, 2024 · 1 comment · May be fixed by #1825
Open

proto: remove optimistic block generated proto files #1823

bharath-123 opened this issue Nov 19, 2024 · 1 comment · May be fixed by #1825

Comments

@bharath-123
Copy link
Contributor

bharath-123 commented Nov 19, 2024 •
edited by sync-by-unito bot
Loading

After #1707 got merged, there are a couple of generated proto files which is basically dead code due to naming and versioning changes in #1707.

We should remove those files and also update https://github.com/astriaorg/astria/blob/main/crates/astria-core/src/generated/mod.rs#L169 to optimistic

┆Issue Number: ENG-1021
@bharath-123 bharath-123 mentioned this issue Nov 19, 2024
Closed
@bharath-123
Copy link
Contributor Author

This issue is being fixed in: #1825

@SuperFluffy SuperFluffy linked a pull request Nov 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bharath-123