Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package version identifier is limited to 18446744073709551615 #8271

Open
dschneiderch opened this issue Oct 16, 2024 · 1 comment
Open

package version identifier is limited to 18446744073709551615 #8271

dschneiderch opened this issue Oct 16, 2024 · 1 comment
Assignees
Labels
needs-decision Undecided if this should be done

Comments

@dschneiderch
Copy link

dschneiderch commented Oct 16, 2024

It seems that UV doesn't support version identifiers great than 18446744073709551615. I don't believe https://peps.python.org/pep-0440/ has this restriction and assume it is a function of using Int64 to parse the build number.

To reproduce simply add a dependency with a dev version identifier > 18446744073709551615.

Internally we are using a concatenation of the hash of a branch name and the git commit to version development packages. We don't use the local identifier syntax because google won't let us install those in the cloud-composer (even though we use a private artifactory) :(

error: Failed to build: `vi-composer @ file:///Users/dschneider/bombora/repos/vi-composer`
  Caused by: Failed to parse metadata from built wheel
  Caused by: expected number less than or equal to 18446744073709551615, but number found in "768230559194918072045" exceeds it
bombora-composer3-airflow2 ==0.2.1.dev768230559194918072045
uv 0.4.13 (b8f9ee3b4 2024-09-19) 

on macos

@charliermarsh charliermarsh added the needs-decision Undecided if this should be done label Oct 16, 2024
@zanieb
Copy link
Member

zanieb commented Oct 17, 2024

It's hard to say if we should support larger integers. I assume it will come with more complexity and performance degradation. Curious to see what @BurntSushi thinks though, as he's the expert on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-decision Undecided if this should be done
Projects
None yet
Development

No branches or pull requests

4 participants