Skip to content

Commit dc86a88

Browse files
committed
linux: build tcl/tk
I'm not yet sure we're building it properly, as we're not yet hooking this package up to the Python build.
1 parent a96a39d commit dc86a88

File tree

5 files changed

+8
-23
lines changed

5 files changed

+8
-23
lines changed

cpython-linux/Makefile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ $(OUTDIR)/readline-$(READLINE_VERSION)-%.tar: $(PYTHON_DEP_DEPENDS) $(OUTDIR)/nc
9292
$(OUTDIR)/sqlite-$(SQLITE_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-sqlite.sh
9393
$(BUILD) --platform $(PLATFORM) sqlite
9494

95-
$(OUTDIR)/tcltk-$(TCL_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-tcltk.sh
95+
$(OUTDIR)/tcl-$(TCL_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-tcltk.sh
9696
$(BUILD) --platform $(PLATFORM) tcltk
9797

9898
$(OUTDIR)/uuid-$(UUID_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-uuid.sh
@@ -113,6 +113,7 @@ PYTHON_DEPENDS := \
113113
$(OUTDIR)/ncurses-$(NCURSES_VERSION)-$(PLATFORM).tar \
114114
$(OUTDIR)/readline-$(READLINE_VERSION)-$(PLATFORM).tar \
115115
$(OUTDIR)/sqlite-$(SQLITE_VERSION)-$(PLATFORM).tar \
116+
$(OUTDIR)/tcl-$(TCL_VERSION)-$(PLATFORM).tar \
116117
$(OUTDIR)/uuid-$(UUID_VERSION)-$(PLATFORM).tar \
117118
$(OUTDIR)/xz-$(XZ_VERSION)-$(PLATFORM).tar \
118119
$(OUTDIR)/zlib-$(ZLIB_VERSION)-$(PLATFORM).tar \

cpython-linux/build-tcltk.sh

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,26 +10,15 @@ cd /build
1010
export PATH=/tools/${TOOLCHAIN}/bin:/tools/host/bin:$PATH
1111

1212
tar -xf tcl8.6.9-src.tar.gz
13-
1413
pushd tcl8.6.9/unix
15-
./configure --prefix=/tools/deps
14+
./configure --prefix=/tools/deps --enable-shared=no
1615
make -j `nproc`
1716
make -j `nproc` install DESTDIR=/build/out
1817
make -j `nproc` install
1918
popd
2019

21-
tar -xf libX11-1.5.0.tar.gz
22-
pushd libX11-1.5.0
23-
./configure --prefix=/tools/deps
24-
make -j `nproc`
25-
make -j `nproc` install DEST=/build/out
26-
make -j `nproc` install
27-
popd
28-
2920
tar -xf tk8.6.9.1-src.tar.gz
3021
pushd tk8.6.9/unix
31-
32-
./configure --prefix=/tools/deps --with-tcl=/tools/deps/lib
33-
22+
./configure --prefix=/tools/deps --with-tcl=/tools/deps/lib --enable-shared=no
3423
make -j `nproc`
3524
make -j `nproc` install DESTDIR=/build/out

cpython-linux/build.Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
RUN apt-get install \
33
file \
44
libc6-dev \
5+
libx11-dev \
56
make \
67
patch \
78
perl \

cpython-linux/build.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -448,26 +448,26 @@ def build_readline(client, image, platform, musl=False):
448448
def build_tcltk(client, image, platform, musl=False):
449449
tcl_archive = download_entry('tcl', BUILD)
450450
tk_archive = download_entry('tk', BUILD)
451-
x11_archive = download_entry('libx11', BUILD)
452451

453452
with run_container(client, image) as container:
454453
copy_toolchain(container, musl=musl)
455454

456455
copy_file_to_container(tcl_archive, container, '/build')
457456
copy_file_to_container(tk_archive, container, '/build')
458-
copy_file_to_container(x11_archive, container, '/build')
459457
copy_file_to_container(SUPPORT / 'build-tcltk.sh', container,
460458
'/build')
461459

462460
env = {
461+
'CC': 'clang',
463462
'TOOLCHAIN': 'clang-%s' % platform,
464463
}
465464

466465
container_exec(container, '/build/build-tcltk.sh',
467466
environment=env)
468467

469468
download_tools_archive(container,
470-
archive_path('tcl', platform, musl=musl))
469+
archive_path('tcl', platform, musl=musl),
470+
'deps')
471471

472472

473473
def python_build_info(container, config_c_in, setup_dist, setup_local, libressl=False):

pythonbuild/downloads.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -158,12 +158,6 @@
158158
'licenses': ['OpenSSL'],
159159
'license_file': 'LICENSE.libressl.txt',
160160
},
161-
'libx11': {
162-
'url': 'https://www.x.org/releases/X11R7.7/src/lib/libX11-1.5.0.tar.gz',
163-
'size': 3073820,
164-
'sha256': '2ddc05170baf70dd650ee6108c5882eb657cafaf61a5b5261badb26703122518',
165-
'version': '1.5.0',
166-
},
167161
'lld': {
168162
'url': 'http://releases.llvm.org/8.0.0/lld-8.0.0.src.tar.xz',
169163
'size': 999864,

0 commit comments

Comments
 (0)