Fix GET group info and invite link by using request parameters and not request body

Author: Nicolás Gudiño

handlers.go

@@ -2621,15 +2621,14 @@ func (s *server) GetGroupInfo() http.HandlerFunc {
 			return
 		}
 
-		decoder := json.NewDecoder(r.Body)
-		var t getGroupInfoStruct
-		err := decoder.Decode(&t)
-		if err != nil {
-			s.Respond(w, r, http.StatusBadRequest, errors.New("Could not decode Payload"))
+		// Get GroupJID from query parameter
+		groupJID := r.URL.Query().Get("groupJID")
+		if groupJID == "" {
+			s.Respond(w, r, http.StatusBadRequest, errors.New("Missing groupJID parameter"))
 			return
 		}
 
-		group, ok := parseJID(t.GroupJID)
+		group, ok := parseJID(groupJID)
 		if !ok {
 			s.Respond(w, r, http.StatusBadRequest, errors.New("Could not parse Group JID"))
 			return
@@ -2674,21 +2673,32 @@ func (s *server) GetGroupInviteLink() http.HandlerFunc {
 			return
 		}
 
-		decoder := json.NewDecoder(r.Body)
-		var t getGroupInfoStruct
-		err := decoder.Decode(&t)
-		if err != nil {
-			s.Respond(w, r, http.StatusBadRequest, errors.New("Could not decode Payload"))
+		// Get GroupJID from query parameter
+		groupJID := r.URL.Query().Get("groupJID")
+		if groupJID == "" {
+			s.Respond(w, r, http.StatusBadRequest, errors.New("Missing groupJID parameter"))
 			return
 		}
 
-		group, ok := parseJID(t.GroupJID)
+		// Get reset parameter
+		resetParam := r.URL.Query().Get("reset")
+		reset := false
+		if resetParam != "" {
+			var err error
+			reset, err = strconv.ParseBool(resetParam)
+			if err != nil {
+				s.Respond(w, r, http.StatusBadRequest, errors.New("Invalid reset parameter, must be true or false"))
+				return
+			}
+		}
+
+		group, ok := parseJID(groupJID)
 		if !ok {
 			s.Respond(w, r, http.StatusBadRequest, errors.New("Could not parse Group JID"))
 			return
 		}
 
-		resp, err := clientPointer[userid].GetGroupInviteLink(group, t.Reset)
+		resp, err := clientPointer[userid].GetGroupInviteLink(group, reset)
 
 		if err != nil {
 			log.Error().Str("error", fmt.Sprintf("%v", err)).Msg("Failed to get group invite link")

static/api/spec.yml

@@ -544,15 +544,22 @@ paths:
         - Group 
       summary: Get Group Invite Link
       description: Gets the invite link for a group, optionally resetting it to create a new/different one
-      requestBody:
-        required: true
-        content:
-          application/json:
-            schema:
-              $ref: '#definitions/GroupInviteLink'
+      parameters:
+        - in: query
+          name: groupJID
+          schema:
+            type: string
+          required: true
+          description: The JID of the group to retrieve information from
+        - in: query
+          name: reset
+          schema:
+            type: boolean
+          required: false
+          description: Whether to revoke the old invite link and generate a new one (default is false)
       responses:
         200:
-          description: Response
+          description: Successfull response
           content:
             application/json:
               schema:
@@ -563,16 +570,16 @@ paths:
         - Group 
       summary: Gets group information
       description: Retrieves information about a specific group
-      requestBody:
-        required: true
-        content:
-          application/json:
-            schema:
-              $ref: '#definitions/GroupInfo'
- 
+      parameters:
+        - in: query
+          name: groupJID
+          schema:
+            type: string
+          required: true
+          description: The JID of the group to retrieve information from
       responses:
         200:
-          description: Response
+          description: Successful response
           content:
             application/json:
               schema: