[DRAFT] Update docstrings and allow AbstractString #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of operations might produce non-standard strings (eg InlineString, SubString{String}), this PR extends the support to such strings as well.
Added a mini test for each just to show that it works.
It also adds docstrings for the two main functions, so people can use the help mode.
This PR should be merged only AFTER we merge the restructure (I'll move things around once that happens)
Some minor changes, eg,
_load_prefix_file
to be an external function, otherwise it gets defined again every time you callPrefixes
inside of the split_sentence.nothing
as opposed tomissing
(missing
is intended more when there is a data point but we don't know what it is versusnothing
is meant when nothing is provided like no argument)x!=nothing
changed to more idiomatic!isnothing(x)
(similar forisempty
)EDIT: sorry, there are a few more "changes" -- I have an auto-formatter enabled. I hope it's okay since there is so little code anyway. We'll re-format everything in the end anyway.