Set process.env.NODE_ENV = 'production' when bundling

[SimenB]

Currently we get the development version of e.g. react in production. Would be nice to avoid that

[trygve-lie]

Is there other ways to tell react to provide prod version than using process.env.NODE_ENV?

vue.js will btw have the same issue.

[SimenB]

Docs says to use process.env.NODE_ENV

https://facebook.github.io/react/docs/optimizing-performance.html#use-the-production-build

[sveisvei]

I think it makes sense to inject NODE_ENV from the server process.env.

[SimenB]

Sorta related: we don't do minification

[SimenB]

@digitalsadhu this is done now, right?

[digitalsadhu]

Minification based on NODE_ENV=production yes.
We didn't end up including envify yet though so still need to revisit that.

[SimenB]

ah, of course.

[digitalsadhu]

We now support minification. Defaults to process.env.NODE_ENV with fallback to 'development' if not defined. Latest client also allows overriding this on any given client call.

[theneva]

market-frontpage on Podium v2 says this:

Looks like we still have a ways to to here

[digitalsadhu]

Wonder what’s up here.
Envify in use here:
https://github.com/asset-pipe/asset-pipe-js-reader/blob/742677c33284069c60f243334337d57a836417d6/lib/reader.js#L74

And I’ve seen this work with react.

[theneva]

Yep, I went digging and couldn't find anything obvious. Will have to continue looking into it tomorrow.