We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A problem with hamcrest matchers is having one class for assertThat(x, matcher) and one for assertThat(x, not(matcher)). For example: https://github.com/assertj/assertj-migrator/blob/main/src/main/java/com/slinkydeveloper/assertjmigrator/migrations/hamcrest/HamcrestAssertThatContainsString.java and https://github.com/assertj/assertj-migrator/blob/main/src/main/java/com/slinkydeveloper/assertjmigrator/migrations/hamcrest/HamcrestAssertThatNotContainsString.java.
assertThat(x, matcher)
assertThat(x, not(matcher))
I think we can easily improve by creating a base class for hamcrest migrations where the abstract methods are similar to these ones: https://github.com/assertj/assertj-migrator/blob/main/src/main/java/com/slinkydeveloper/assertjmigrator/migrations/common/PredicateMigrator.java#L73
The text was updated successfully, but these errors were encountered:
No branches or pull requests
A problem with hamcrest matchers is having one class for
assertThat(x, matcher)
and one forassertThat(x, not(matcher))
. For example: https://github.com/assertj/assertj-migrator/blob/main/src/main/java/com/slinkydeveloper/assertjmigrator/migrations/hamcrest/HamcrestAssertThatContainsString.java and https://github.com/assertj/assertj-migrator/blob/main/src/main/java/com/slinkydeveloper/assertjmigrator/migrations/hamcrest/HamcrestAssertThatNotContainsString.java.I think we can easily improve by creating a base class for hamcrest migrations where the abstract methods are similar to these ones: https://github.com/assertj/assertj-migrator/blob/main/src/main/java/com/slinkydeveloper/assertjmigrator/migrations/common/PredicateMigrator.java#L73
The text was updated successfully, but these errors were encountered: