Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent naming for UpdateBrandCommand Handler #27

Open
tanczosm opened this issue Apr 2, 2021 · 1 comment
Open

Inconsistent naming for UpdateBrandCommand Handler #27

tanczosm opened this issue Apr 2, 2021 · 1 comment

Comments

@tanczosm
Copy link

tanczosm commented Apr 2, 2021

Describe the bug
This is not so much a bug as a coding mistake.

/Boilerplate/blob/master/AspNetCoreHero.Boilerplate.Application/Features/Brands/Commands/Update/UpdateBrandCommand.cs

This looks like it may have been a copy of UpdateProductCommand.cs that was altered to suit Brand. The handler inside the UpdateBrandCommand is called UpdateProductCommandHandler instead of UpdateBrandCommandHandler.
@ravarador
Copy link

Same goes with IBrandCache repository and IProductCacheRepository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tanczosm @ravarador