Added support to .NET Standard #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like it could be really useful - especially when combined with the SystemWeb-Adapters project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entity Framework 6.4 is supported with the new .NET, but many developers also use the ASP.NET Identity Entity Framework. Their
DbContextinherits fromIdentityDbContext, making the migration to the new .NET impossible.I have ported the
Microsoft.AspNet.Identity.CoreandMicrosoft.AspNet.Identity.EntityFrameworktonetstandard2.1;net45- the same targets asEntityFrameworkpackage has.I have also copied the
Owinhosting project and addedAspNetCoreversion that tries to replicate its functionality as closely as possible - only removes many helper extension methods that seem to be redundant to the API we have in ASP.NET Core.I have also gone through all tests and made them working on both versions (except for the tests of
IAuthenticationManagerAPI which is not present in the new .NET at all).I am not sure if this PR can ever get merged as it is an old security-related library which probably has to go through some security review. Also, maybe it is not a good idea to encourage people to potentially use the old version ASP.NET Identity in new projects. However, I found it useful in several modernization projects as it allowed me to keep using EF6 temporarily and not to migrate everything at the same time.