From d4358cf48a14cbd9ad58607faff5cf646afca09d Mon Sep 17 00:00:00 2001
From: Colin Stewart <79332690+costdev@users.noreply.github.com>
Date: Sun, 1 Dec 2024 10:09:00 +0000
Subject: [PATCH] Add tests for `API_Rewrite::pre_http_request()` (#218)

---
 .../APIRewrite_PreHttpRequestTest.php         | 131 ++++++++++++++++++
 .../AdminSettings_GetSettingTest.php          |   6 +
 2 files changed, 137 insertions(+)
 create mode 100644 tests/phpunit/tests/API_Rewrite/APIRewrite_PreHttpRequestTest.php

diff --git a/tests/phpunit/tests/API_Rewrite/APIRewrite_PreHttpRequestTest.php b/tests/phpunit/tests/API_Rewrite/APIRewrite_PreHttpRequestTest.php
new file mode 100644
index 0000000..4d7805d
--- /dev/null
+++ b/tests/phpunit/tests/API_Rewrite/APIRewrite_PreHttpRequestTest.php
@@ -0,0 +1,131 @@
+<?php
+/**
+ * Class APIRewrite_PreHttpRequestTest
+ *
+ * @package AspireUpdate
+ */
+
+/**
+ * Tests for API_Rewrite::pre_http_request()
+ *
+ * @covers \AspireUpdate\API_Rewrite::pre_http_request
+ */
+class APIRewrite_PreHttpRequestTest extends WP_UnitTestCase {
+	/**
+	 * Test that no request is performed when the redirected host is an empty string.
+	 */
+	public function test_should_not_perform_request_when_redirected_host_is_an_empty_string() {
+		$request = new MockAction();
+		add_filter( 'pre_http_request', [ $request, 'filter' ] );
+
+		$api_rewrite = new AspireUpdate\API_Rewrite( '', false );
+		$api_rewrite->pre_http_request( [], [], '' );
+
+		$this->assertSame( 0, $request->get_call_count() );
+	}
+
+	/**
+	 * Test that no request is performed when the default host and redirected host are the same.
+	 */
+	public function test_should_not_perform_request_when_default_host_and_redirected_host_are_the_same() {
+		$request = new MockAction();
+		add_filter( 'pre_http_request', [ $request, 'filter' ] );
+
+		$default_host = $this->get_default_host();
+		$api_rewrite  = new AspireUpdate\API_Rewrite( $default_host, false );
+
+		$api_rewrite->pre_http_request( [], [], $default_host );
+
+		$this->assertSame( 0, $request->get_call_count() );
+	}
+
+	/**
+	 * Test that the request's original SSL verification is respected when SSL is not forcibly disabled.
+	 */
+	public function test_should_respect_the_original_ssl_verification_when_ssl_is_not_forcibly_disabled() {
+		$actual = '';
+
+		add_filter(
+			'pre_http_request',
+			static function ( $response, $parsed_args ) use ( &$actual ) {
+				$actual = $parsed_args['sslverify'];
+				return $response;
+			},
+			PHP_INT_MAX,
+			2
+		);
+
+		$api_rewrite = new AspireUpdate\API_Rewrite( 'my.api.org', false );
+		$api_rewrite->pre_http_request(
+			[],
+			[ 'sslverify' => 'original_sslverify_value' ],
+			$this->get_default_host()
+		);
+
+		$this->assertSame( 'original_sslverify_value', $actual );
+	}
+
+	/**
+	 * Test that disabling SSL is respected.
+	 */
+	public function test_should_respect_disabling_ssl() {
+		$actual = '';
+
+		add_filter(
+			'pre_http_request',
+			static function ( $response, $parsed_args ) use ( &$actual ) {
+				$actual = $parsed_args['sslverify'];
+				return $response;
+			},
+			PHP_INT_MAX,
+			2
+		);
+
+		$api_rewrite = new AspireUpdate\API_Rewrite( 'my.api.org', true );
+		$api_rewrite->pre_http_request(
+			[],
+			[ 'sslverify' => true ],
+			$this->get_default_host()
+		);
+
+		$this->assertFalse( $actual );
+	}
+
+	/**
+	 * Test that the default host is replaced with the redirected host.
+	 */
+	public function test_should_replace_default_host_with_redirected_host() {
+		$actual = '';
+
+		add_filter(
+			'pre_http_request',
+			static function ( $response, $parsed_args, $url ) use ( &$actual ) {
+				$actual = $url;
+				return $response;
+			},
+			PHP_INT_MAX,
+			3
+		);
+
+		$api_rewrite = new AspireUpdate\API_Rewrite( 'my.api.org', true );
+		$api_rewrite->pre_http_request( [], [], $this->get_default_host() );
+
+		$this->assertSame( 'my.api.org', $actual );
+	}
+
+	/**
+	 * Gets the default host.
+	 *
+	 * @return string The default host.
+	 */
+	private function get_default_host() {
+		static $default_host;
+
+		if ( ! $default_host ) {
+			$reflection   = new ReflectionClass( 'AspireUpdate\API_Rewrite' );
+			$default_host = $reflection->getDefaultProperties()['default_host'];
+		}
+
+		return $default_host;
+	}
+}
diff --git a/tests/phpunit/tests/AdminSettings/AdminSettings_GetSettingTest.php b/tests/phpunit/tests/AdminSettings/AdminSettings_GetSettingTest.php
index 8ddfc14..267b1a1 100644
--- a/tests/phpunit/tests/AdminSettings/AdminSettings_GetSettingTest.php
+++ b/tests/phpunit/tests/AdminSettings/AdminSettings_GetSettingTest.php
@@ -8,6 +8,12 @@
 /**
  * Tests for Admin_Settings::get_setting()
  *
+ * These tests cause constants to be defined.
+ * They must run in separate processes and must not preserve global state.
+ *
+ * @runTestsInSeparateProcesses
+ * @preserveGlobalState disabled
+ *
  * @covers \AspireUpdate\Admin_Settings::get_setting
  */
 class AdminSettings_GetSettingTest extends AdminSettings_UnitTestCase {