Skip to content

Conversation

@sallustfire
Copy link
Contributor

Added tests exercised by CI to demonstrate eslint usage of tsconfig.json.

#602 (review)


Changes are visible to end-users: no

@aspect-workflows
Copy link

aspect-workflows bot commented Sep 12, 2025

Test

All tests were cache hits

4 tests (100.0%) were fully cached saving 2s.


Test

docs

All tests were cache hits

15 tests (100.0%) were fully cached saving 672ms.


Test

example

7 test targets passed

Targets
//tools/format:format_test_JavaScript_with_prettier [k8-fastbuild]14s
//tools/format:format_test_Markdown_with_prettier [k8-fastbuild]1s
//tools/format:format_test_Protocol_Buffer_with_buf [k8-fastbuild]1s
//tools/format:format_test_Python_with_ruff [k8-fastbuild]475ms
//tools/format:format_test_SQL_with_prettier [k8-fastbuild]3s
//tools/format:format_test_Scala_with_scalafmt [k8-fastbuild]4s
//tools/format:format_test_Starlark_with_buildifier [k8-fastbuild]768ms

Total test execution time was 25s. 27 tests (79.4%) were fully cached saving 7s.


Test (WORKSPACE) (Test)

example

7 test targets passed

Targets
//tools/format:format_test_JavaScript_with_prettier [k8-fastbuild]19s
//tools/format:format_test_Markdown_with_prettier [k8-fastbuild]2s
//tools/format:format_test_Protocol_Buffer_with_buf [k8-fastbuild]856ms
//tools/format:format_test_Python_with_ruff [k8-fastbuild]323ms
//tools/format:format_test_SQL_with_prettier [k8-fastbuild]2s
//tools/format:format_test_Scala_with_scalafmt [k8-fastbuild]6s
//tools/format:format_test_Starlark_with_buildifier [k8-fastbuild]312ms

Total test execution time was 30s. 11 tests (61.1%) were fully cached saving 8s.


Lint [.]      Lint [docs]      Lint [example]

@sallustfire
Copy link
Contributor Author

sallustfire commented Sep 12, 2025

@alexeagle I was debugging support for the tsconfig transitive closure in eslint. Turned out my problem was a typescript import resolver error in the eslint tooling and not rules_lint. However, I thought you might like to have a load bearing test for the tsconfig functionality.

refute_output --partial "Unexpected 'debugger' statement"
}

#@test "should include tsconfig when linting ts_project targets" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this meant to be un-commented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies. This was an earlier version of explicitly testing type aware lint rules. It's sufficient to use the primary assert_lints because eslint will notify that it can't find the tsconfig for rules that require it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants