-
-
Notifications
You must be signed in to change notification settings - Fork 82
chore: test tsconfig input to type-aware eslint #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
@alexeagle I was debugging support for the tsconfig transitive closure in eslint. Turned out my problem was a typescript import resolver error in the eslint tooling and not rules_lint. However, I thought you might like to have a load bearing test for the tsconfig functionality. |
example/test/lint_test.bats
Outdated
| refute_output --partial "Unexpected 'debugger' statement" | ||
| } | ||
|
|
||
| #@test "should include tsconfig when linting ts_project targets" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this meant to be un-commented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies. This was an earlier version of explicitly testing type aware lint rules. It's sufficient to use the primary assert_lints because eslint will notify that it can't find the tsconfig for rules that require it.


Added tests exercised by CI to demonstrate eslint usage of tsconfig.json.
#602 (review)
Changes are visible to end-users: no