Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: node:fs/promises is not patched, leading to sandbox/runfiles escape #1827

Open
matthewjh opened this issue Jun 28, 2024 · 0 comments
Open

[Bug]: node:fs/promises is not patched, leading to sandbox/runfiles escape #1827

matthewjh opened this issue Jun 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@matthewjh
Copy link

What happened?

Hi, I noticed that the fs patches apply to node:fs but not to node:fs/promises. This causes problems with sandbox escape in some tools.

Version

Development (host) and target OS/architectures:

Output of bazel --version:

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:

rules_js 1.41.1

Language(s) and/or frameworks involved:
node v18.16

How to reproduce

No response

Any other information?

No response
@matthewjh matthewjh added the bug Something isn't working label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matthewjh