From adc9b6fedb0fdc43ee264a511e88022cbfb0003e Mon Sep 17 00:00:00 2001
From: Asis Pattisahusiwa <79239132+asispts@users.noreply.github.com>
Date: Fri, 3 Nov 2023 19:40:30 +0700
Subject: [PATCH] Use static closure if possible (#19)

---
 ptscs/ruleset.xml                             |  1 +
 .../Slevomat/Functions/StaticClosureTest.php  | 23 +++++++++++++++++++
 .../Functions/_data/StaticClosure.php.fixed   | 13 +++++++++++
 .../Functions/_data/StaticClosure.php.inc     | 13 +++++++++++
 ...InheritedVariablePassedToClosure.php.fixed |  2 +-
 ...edInheritedVariablePassedToClosure.php.inc |  2 +-
 .../Unsolved/_data/ScopeIndent.php.fixed      |  2 +-
 .../Sniffs/Unsolved/_data/ScopeIndent.php.inc |  2 +-
 8 files changed, 54 insertions(+), 4 deletions(-)
 create mode 100644 tests/Sniffs/Slevomat/Functions/StaticClosureTest.php
 create mode 100644 tests/Sniffs/Slevomat/Functions/_data/StaticClosure.php.fixed
 create mode 100644 tests/Sniffs/Slevomat/Functions/_data/StaticClosure.php.inc

diff --git a/ptscs/ruleset.xml b/ptscs/ruleset.xml
index 7675c2a..fb30393 100644
--- a/ptscs/ruleset.xml
+++ b/ptscs/ruleset.xml
@@ -193,6 +193,7 @@
     <rule ref="SlevomatCodingStandard.Variables.UnusedVariable" />
     <rule ref="SlevomatCodingStandard.Functions.UnusedInheritedVariablePassedToClosure" />
     <rule ref="SlevomatCodingStandard.Functions.DisallowEmptyFunction" />
+    <rule ref="SlevomatCodingStandard.Functions.StaticClosure" />
     <rule ref="SlevomatCodingStandard.Commenting.DisallowOneLinePropertyDocComment" />
     <rule ref="SlevomatCodingStandard.Commenting.EmptyComment" />
 
diff --git a/tests/Sniffs/Slevomat/Functions/StaticClosureTest.php b/tests/Sniffs/Slevomat/Functions/StaticClosureTest.php
new file mode 100644
index 0000000..760f348
--- /dev/null
+++ b/tests/Sniffs/Slevomat/Functions/StaticClosureTest.php
@@ -0,0 +1,23 @@
+<?php declare(strict_types=1);
+
+namespace Ptscs\Tests\Sniffs\Slevomat\Functions;
+
+use Iterator;
+use Ptscs\Tests\SniffTestCase;
+use Ptscs\Tests\Utils\ErrorData;
+
+final class StaticClosureTest extends SniffTestCase
+{
+    protected function setUp(): void
+    {
+        parent::setUp();
+        $this->appendExclude('Squiz.Classes.ClassFileName.NoMatch');
+    }
+
+    public static function provideTestData(): Iterator
+    {
+        yield[
+          [new ErrorData(9, 'SlevomatCodingStandard.Functions.StaticClosure.ClosureNotStatic')],
+        ];
+    }
+}
diff --git a/tests/Sniffs/Slevomat/Functions/_data/StaticClosure.php.fixed b/tests/Sniffs/Slevomat/Functions/_data/StaticClosure.php.fixed
new file mode 100644
index 0000000..c40f8da
--- /dev/null
+++ b/tests/Sniffs/Slevomat/Functions/_data/StaticClosure.php.fixed
@@ -0,0 +1,13 @@
+<?php declare(strict_types=1);
+
+namespace App;
+
+final class Foobar
+{
+    public function callback()
+    {
+        return static function () {
+            return 'Test';
+        };
+    }
+}
diff --git a/tests/Sniffs/Slevomat/Functions/_data/StaticClosure.php.inc b/tests/Sniffs/Slevomat/Functions/_data/StaticClosure.php.inc
new file mode 100644
index 0000000..3c34630
--- /dev/null
+++ b/tests/Sniffs/Slevomat/Functions/_data/StaticClosure.php.inc
@@ -0,0 +1,13 @@
+<?php declare(strict_types=1);
+
+namespace App;
+
+final class Foobar
+{
+    public function callback()
+    {
+        return function () {
+            return 'Test';
+        };
+    }
+}
diff --git a/tests/Sniffs/Slevomat/_data/UnusedInheritedVariablePassedToClosure.php.fixed b/tests/Sniffs/Slevomat/_data/UnusedInheritedVariablePassedToClosure.php.fixed
index 9fc64a2..acbfb15 100644
--- a/tests/Sniffs/Slevomat/_data/UnusedInheritedVariablePassedToClosure.php.fixed
+++ b/tests/Sniffs/Slevomat/_data/UnusedInheritedVariablePassedToClosure.php.fixed
@@ -6,7 +6,7 @@ final class Foobar
 {
     public function __invoke(): callable
     {
-        return function () {
+        return static function () {
         };
     }
 }
diff --git a/tests/Sniffs/Slevomat/_data/UnusedInheritedVariablePassedToClosure.php.inc b/tests/Sniffs/Slevomat/_data/UnusedInheritedVariablePassedToClosure.php.inc
index 1f9ce5c..ded8dab 100644
--- a/tests/Sniffs/Slevomat/_data/UnusedInheritedVariablePassedToClosure.php.inc
+++ b/tests/Sniffs/Slevomat/_data/UnusedInheritedVariablePassedToClosure.php.inc
@@ -6,7 +6,7 @@ final class Foobar
 {
     public function __invoke(): callable
     {
-        return function () use ($name) {
+        return static function () use ($name) {
         };
     }
 }
diff --git a/tests/Sniffs/Unsolved/_data/ScopeIndent.php.fixed b/tests/Sniffs/Unsolved/_data/ScopeIndent.php.fixed
index 160b640..9ec8ecc 100644
--- a/tests/Sniffs/Unsolved/_data/ScopeIndent.php.fixed
+++ b/tests/Sniffs/Unsolved/_data/ScopeIndent.php.fixed
@@ -1,6 +1,6 @@
 <?php declare(strict_types=1);
 
-$this->callback(function () {
+$this->callback(static function () {
     if (true) {
     }
 
diff --git a/tests/Sniffs/Unsolved/_data/ScopeIndent.php.inc b/tests/Sniffs/Unsolved/_data/ScopeIndent.php.inc
index 160b640..9ec8ecc 100644
--- a/tests/Sniffs/Unsolved/_data/ScopeIndent.php.inc
+++ b/tests/Sniffs/Unsolved/_data/ScopeIndent.php.inc
@@ -1,6 +1,6 @@
 <?php declare(strict_types=1);
 
-$this->callback(function () {
+$this->callback(static function () {
     if (true) {
     }