From 125dddd46afcdd97da8d551ec68454034ea0916c Mon Sep 17 00:00:00 2001
From: Asis Pattisahusiwa <79239132+asispts@users.noreply.github.com>
Date: Fri, 10 Nov 2023 20:20:36 +0700
Subject: [PATCH] Detect and remove useless semicolon (#23)

---
 ptscs/ruleset.xml                             |  1 +
 .../Slevomat/PHP/UselessSemicolonTest.php     | 19 +++++++++++++++++++
 .../PHP/_data/UselessSemicolon.php.fixed      |  1 +
 .../PHP/_data/UselessSemicolon.php.inc        |  1 +
 4 files changed, 22 insertions(+)
 create mode 100644 tests/Sniffs/Slevomat/PHP/UselessSemicolonTest.php
 create mode 100644 tests/Sniffs/Slevomat/PHP/_data/UselessSemicolon.php.fixed
 create mode 100644 tests/Sniffs/Slevomat/PHP/_data/UselessSemicolon.php.inc

diff --git a/ptscs/ruleset.xml b/ptscs/ruleset.xml
index 187d1f5..f2c0692 100644
--- a/ptscs/ruleset.xml
+++ b/ptscs/ruleset.xml
@@ -206,6 +206,7 @@
 
     <rule ref="SlevomatCodingStandard.Operators.DisallowEqualOperators" />
     <rule ref="SlevomatCodingStandard.PHP.UselessParentheses" />
+    <rule ref="SlevomatCodingStandard.PHP.UselessSemicolon" />
 
     <!--++++++++++++++++++++++++++++++++++++
     Code analysis
diff --git a/tests/Sniffs/Slevomat/PHP/UselessSemicolonTest.php b/tests/Sniffs/Slevomat/PHP/UselessSemicolonTest.php
new file mode 100644
index 0000000..fca1221
--- /dev/null
+++ b/tests/Sniffs/Slevomat/PHP/UselessSemicolonTest.php
@@ -0,0 +1,19 @@
+<?php declare(strict_types=1);
+
+namespace Ptscs\Tests\Sniffs\Slevomat\PHP;
+
+use Iterator;
+use Ptscs\Tests\SniffTestCase;
+use Ptscs\Tests\Utils\ErrorData;
+
+final class UselessSemicolonTest extends SniffTestCase
+{
+    public static function provideTestData(): Iterator
+    {
+        yield[
+          [
+            new ErrorData(1, 'SlevomatCodingStandard.PHP.UselessSemicolon.UselessSemicolon'),
+          ],
+        ];
+    }
+}
diff --git a/tests/Sniffs/Slevomat/PHP/_data/UselessSemicolon.php.fixed b/tests/Sniffs/Slevomat/PHP/_data/UselessSemicolon.php.fixed
new file mode 100644
index 0000000..f4165e8
--- /dev/null
+++ b/tests/Sniffs/Slevomat/PHP/_data/UselessSemicolon.php.fixed
@@ -0,0 +1 @@
+<?php declare(strict_types=1);
diff --git a/tests/Sniffs/Slevomat/PHP/_data/UselessSemicolon.php.inc b/tests/Sniffs/Slevomat/PHP/_data/UselessSemicolon.php.inc
new file mode 100644
index 0000000..fade2c4
--- /dev/null
+++ b/tests/Sniffs/Slevomat/PHP/_data/UselessSemicolon.php.inc
@@ -0,0 +1 @@
+<?php declare(strict_types=1);;