Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulationSummary reactive not found when Output Summary tab selected #20

Open
bryce-carson opened this issue Jun 12, 2024 · 0 comments
Assignees
Labels
bug Something isn't working UNSTABLE The work is to be completed in the unstable branch

Comments

@bryce-carson
Copy link
Collaborator

Strangely, the reactive indeed exists and is used by three different renderers in the Plot tab. Why it is not found when the selected tab is Output Summary is a mystery to me.

@bryce-carson bryce-carson added the bug Something isn't working label Jun 12, 2024
bryce-carson added a commit to bryce-carson/spatialEpisim that referenced this issue Jun 12, 2024
Remove the modelling approach radio buttons (fix ashokkrish#2). No link to non-spatial
Episim is introduced, the radio buttons are simply removed.

Reimplement the cumulative deaths, cumulative disease incidence, and daily
disease incidence plots using good practices and the correct data (fix ashokkrish#4).

Increase the minimum aggregation factor to one (fix ashokkrish#10).

Change the default selected country to NA (no country is selected by default,
the user must select one); change the default selection of the cropping checkbox
to FALSE (no cropping by default); and remove the default provinces from the
Democratic Republic of Congo when cropping is enabled (if the user enables
cropping while the DRC is the selected country, they must manually enter the
provinces they wish to crop to; fix ashokkrish#16).

A temporary solution to ashokkrish#20 is introduced; a FIXME is written there to remind
programmers that they should the simulationSummary reactive rather than the
duplicated code (which offers a temporary solution).
@bryce-carson bryce-carson added the UNSTABLE The work is to be completed in the unstable branch label Jul 18, 2024
@bryce-carson bryce-carson self-assigned this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UNSTABLE The work is to be completed in the unstable branch
Projects
None yet
Development

No branches or pull requests

1 participant