Skip to content

Local build fixes #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Local build fixes #863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8af10f
Escape '#' in local package path.
Oct 30, 2021
7bf4ae2
Install roslyn-branches npm modules during setup
Oct 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion #scripts/setup.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,18 @@ if ($LastExitCode -ne 0) {
throw "dotnet failed with exit code $LastExitCode"
}

Write-Host "Installing node modules: roslyn-branches" -ForegroundColor White
Push-Location "$PSScriptRoot/roslyn-branches"
try {
npm ci
if ($LastExitCode -ne 0) {
throw "npm ci failed with exit code $LastExitCode"
}
}
finally {
Pop-Location
}

Write-Host "Preparing externals: mirrorsharp" -ForegroundColor White
Push-Location './source/#external/mirrorsharp/WebAssets'
try {
Expand Down Expand Up @@ -51,4 +63,4 @@ Write-Host ""
Write-Host "SharpLab setup done." -ForegroundColor White
Write-Host "Run " -ForegroundColor White -NoNewLine
Write-Host "sl run" -ForegroundColor Cyan -NoNewLine
Write-Host " to start." -ForegroundColor White -NoNewLine
Write-Host " to start." -ForegroundColor White -NoNewLine
2 changes: 1 addition & 1 deletion source/WebApp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
"dateformat": "1.0.12",
"lz-string": "1.4.4",
"marked": "0.7.0",
"mirrorsharp": "file:../#external/mirrorsharp/WebAssets/dist",
"mirrorsharp": "file:../%23external/mirrorsharp/WebAssets/dist",
Copy link
Owner

@ashmind ashmind Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fully sure about this one -- I think I tried this before and run into some problems.
I'll need to try it out again before merging.

"mirrorsharp-codemirror-6-preview": "0.0.11",
"normalize.css": "8.0.1",
"portal-vue": "2.1.7",
Expand Down