Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for ash_postgres.squash_snapshots mix task #301

Closed
vonagam opened this issue May 25, 2024 · 1 comment
Closed

Proposal for ash_postgres.squash_snapshots mix task #301

vonagam opened this issue May 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@vonagam
Copy link
Contributor

vonagam commented May 25, 2024

The idea is simple - a task to clean up snapshots and remove all but last ones.

With usual flags --check, --dry-run, --snapshot-path and --quiet. Plus --into flag that can take first, last or zero and determines the name for a remaining snapshot (first, last are self-explanatory, zero means name with fourteen zeros).

The additional bonus of such task is that its usage (with --into first or --into zero and --check for CI) can help with problems currently present when multiple branches generate migrations and then get merged. The problems that #75 should fix. But unlike operations this task can be implemented quite trivially (and squashing will still make sense to have even after operations are in place).

This is a thing that I had proposed on Discord relatively recently. Just want to confirm the judgement on it. No pressure from me, if it does not fit in the official package I might do it as a separate package then.

@vonagam vonagam added enhancement New feature or request needs review labels May 25, 2024
@zachdaniel
Copy link
Contributor

I'm happy to see the task exist 👍 It will be entirely different once operations exist, but the concept wouldn't go away.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants