Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for php 8.x #22

Open
hebinet opened this issue Mar 21, 2021 · 8 comments · May be fixed by #37
Open

Support for php 8.x #22

hebinet opened this issue Mar 21, 2021 · 8 comments · May be fixed by #37

Comments

@hebinet
Copy link

hebinet commented Mar 21, 2021

Hello,
thanks for this package!
It would be nice if it is compatible with php 8.x

A simple "php": "^7.2|^8.0" in composer.json should be enough.

Kind regards.

@ioanschmitt
Copy link

Would be nice!

@evertonpaiva
Copy link

It woub be great! I'm waiting for it. Thanks!

@niektenhoopen
Copy link

There is already an unmerged PR for this: #16 (actually there is another PR: #15 but #16 is better)

@bfiessinger
Copy link

should be closed by e15bd41

@niektenhoopen
Copy link

should be closed by e15bd41

That's not for PHP8 support right?

@bfiessinger
Copy link

@niektenhoopen not only but php8 has been added there through the dependencies

@niektenhoopen
Copy link

@niektenhoopen not only but php8 has been added there through the dependencies

It's locked to PHP ^7.2 in the comment you refer to. That is 7.x and not 8.

@bfiessinger
Copy link

bfiessinger commented Aug 26, 2021

It's locked to PHP ^7.2 in the comment you refer to. That is 7.x and not 8.

oh.. I must have misread the line so..
But refering to the composer.json changes got applied in bb58c58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants