Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the "coords" kwarg to plot_autocorr #2288

Open
jaredsagendorf opened this issue Nov 9, 2023 · 2 comments · May be fixed by #2404
Open

Add the "coords" kwarg to plot_autocorr #2288

jaredsagendorf opened this issue Nov 9, 2023 · 2 comments · May be fixed by #2404

Comments

@jaredsagendorf
Copy link

jaredsagendorf commented Nov 9, 2023 •
edited
Loading

Tell us about it

Unlike most of the plotting functions, for some reason plot_autocorr doesn't support the coords kwarg. Unless this was intentionally left out, seems like it would be more convenient to include this option.

Also, there is no reference to the grey band that is automatically drawn anywhere I could find. What does this interval represent? The plotting function provides no ability to toggle this, which it should.
@SuramyaP
Copy link

Can I work on this?

@lucifer4073
Copy link

lucifer4073 commented Dec 20, 2024 •
edited
Loading

Hi, I would like to work on this.
I believe the grey band draw depicts the confidence interval. Adding the coords arg in the function can be helpful.

@lucifer4073 lucifer4073 linked a pull request Dec 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Coords kwarg added to plot_autocorr function lucifer4073/arviz_contribution
3 participants
@jaredsagendorf @lucifer4073 @SuramyaP