From b337cae64153225b4766bd62698aa2397dacb077 Mon Sep 17 00:00:00 2001
From: araujobarret <araujobarret@gmail.com>
Date: Wed, 3 Jul 2024 11:44:23 +0200
Subject: [PATCH] feat: remove other_relevant_positions from isProfileComplete

---
 src/schema/v2/CollectorProfile/collectorProfile.ts   | 8 ++------
 src/schema/v2/me/__tests__/collector_profile.test.js | 3 ---
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/src/schema/v2/CollectorProfile/collectorProfile.ts b/src/schema/v2/CollectorProfile/collectorProfile.ts
index 6deae3e384..48fc8032cb 100644
--- a/src/schema/v2/CollectorProfile/collectorProfile.ts
+++ b/src/schema/v2/CollectorProfile/collectorProfile.ts
@@ -212,12 +212,8 @@ export const CollectorProfileFields: GraphQLFieldConfigMap<
   },
   isProfileComplete: {
     type: GraphQLBoolean,
-    resolve: ({ icon, name, location, profession, other_relevant_positions }) =>
-      !!icon &&
-      !!name &&
-      !!location?.display &&
-      !!profession &&
-      !!other_relevant_positions,
+    resolve: ({ icon, name, location, profession }) =>
+      !!icon && !!name && !!location?.display && !!profession,
   },
   summarySentence: {
     type: new GraphQLNonNull(GraphQLString),
diff --git a/src/schema/v2/me/__tests__/collector_profile.test.js b/src/schema/v2/me/__tests__/collector_profile.test.js
index fad38d7768..b78d7b0b4d 100644
--- a/src/schema/v2/me/__tests__/collector_profile.test.js
+++ b/src/schema/v2/me/__tests__/collector_profile.test.js
@@ -89,7 +89,6 @@ describe("Me", () => {
             display: "Berlin",
           },
           profession: "coder",
-          other_relevant_positions: "other typer",
         }
 
         const context = {
@@ -122,8 +121,6 @@ describe("Me", () => {
             display: "Berlin",
           },
           profession: "",
-          other_relevant_positions: "no one knows",
-          bio: "¯\\_(ツ)_//¯",
         }
 
         const context = {