Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hokusai setup/run to balk if executed in a non-git directory. #267

Open
artsyjian opened this issue Sep 17, 2021 · 0 comments
Open

hokusai setup/run to balk if executed in a non-git directory. #267

artsyjian opened this issue Sep 17, 2021 · 0 comments
Labels
low low importance

Comments

@artsyjian
Copy link
Contributor

It seems hokusai setup can be run in any directory.

A first-time Hokusai user is likely to run setup in home directory. I demonstrate:

artsy:~ jxu$ hokusai setup
Created project repo 585031190124.dkr.ecr.us-east-1.amazonaws.com/jxu

And, unknowingly creates a Docker repository named after the home dir (as well as dropping Hokusai ymls into the dir). Over time, a lot of these empty Docker repos are created.

hokusai staging/production run... can also be executed in any directory and if done it spawns a Kubernetes pod that attempts to pull Docker image from a repository named after that directory, and crash loops.

I would like Hokusai to be more strict about the directory where these commands can be run, probably allow them only in Git local repos.

@artsyjian artsyjian added the low low importance label Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low low importance
Projects
None yet
Development

No branches or pull requests

1 participant