feat: shallow partner and artist in Artwork data when possible

araujobarret · araujobarret · commit 84a5ac585731 · 2024-11-21T08:59:21.000+01:00
diff --git a/src/app/Components/Artist/ArtistArtworks/CreateArtworkAlertModal.tsx b/src/app/Components/Artist/ArtistArtworks/CreateArtworkAlertModal.tsx
@@ -34,7 +34,7 @@ export const CreateArtworkAlertModal: React.FC<CreateArtworkAlertModalProps> = (
         internalID
         slug
         isEligibleToCreateAlert
-        artistsArray: artists {
+        artists(shallow: true) {
           internalID
           name
         }
@@ -92,7 +92,7 @@ export const computeArtworkAlertProps = (
   let aggregations: Aggregations = []
   let additionalGeneIDs: string[] = []
 
-  const artists = compact(artwork?.artistsArray)
+  const artists = compact(artwork?.artists)
   const attributionClass = compact([artwork?.attributionClass?.internalID])
   const formattedArtists: SavedSearchEntityArtist[] = artists.map((artist) => ({
     id: artist.internalID,
diff --git a/src/app/Components/ArtworkGrids/ArtworkGridItem.tsx b/src/app/Components/ArtworkGrids/ArtworkGridItem.tsx
@@ -539,7 +539,7 @@ export default createFragmentContainer(Artwork, {
         endAt
         extendedBiddingEndAt
       }
-      partner {
+      partner(shallow: true) {
         name
       }
       image(includeAll: $includeAllImages) {
diff --git a/src/app/Components/ArtworkRail/ArtworkRailCardMeta.tsx b/src/app/Components/ArtworkRail/ArtworkRailCardMeta.tsx
@@ -272,7 +272,7 @@ const artworkMetaFragment = graphql`
       }
     }
     saleMessage
-    partner {
+    partner(shallow: true) {
       name
     }
     title
diff --git a/src/app/Components/ContextMenu/ContextMenuArtworkPreviewCard.tsx b/src/app/Components/ContextMenu/ContextMenuArtworkPreviewCard.tsx
@@ -145,7 +145,7 @@ const artworkFragment = graphql`
       endAt
       extendedBiddingEndAt
     }
-    partner {
+    partner(shallow: true) {
       name
     }
   }
diff --git a/src/app/Scenes/Activity/components/PartnerOfferCreatedNotification.tsx b/src/app/Scenes/Activity/components/PartnerOfferCreatedNotification.tsx
@@ -173,7 +173,7 @@ export const PartnerOfferCreatedNotificationFragment = graphql`
       edges {
         node {
           internalID
-          partner {
+          partner(shallow: true) {
             profile {
               icon {
                 url(version: "square140")
diff --git a/src/app/Scenes/Artwork/Artwork.tsx b/src/app/Scenes/Artwork/Artwork.tsx
@@ -732,7 +732,7 @@ export const ArtworkContainer = createRefetchContainer(
           type
           isInquireable
         }
-        artist {
+        artist(shallow: true) {
           biographyBlurb {
             text
           }
@@ -774,7 +774,7 @@ export const ArtworkContainer = createRefetchContainer(
             }
           }
         }
-        artists {
+        artists(shallow: true) {
           isConsignable
         }
         isEligibleForArtsyGuarantee
diff --git a/src/app/Scenes/Artwork/Components/AboutArtist.tsx b/src/app/Scenes/Artwork/Components/AboutArtist.tsx
@@ -71,15 +71,15 @@ export const AboutArtistFragmentContainer = createFragmentContainer(AboutArtist,
   artwork: graphql`
     fragment AboutArtist_artwork on Artwork {
       displayArtistBio
-      artists {
+      artists(shallow: true) {
         id
         biographyBlurb {
           text
         }
 
         ...ArtistListItem_artist
       }
-      artist {
+      artist(shallow: true) {
         partnerBiographyBlurb {
           text
         }
diff --git a/src/app/Scenes/Artwork/Components/ArtworkConsignments.tsx b/src/app/Scenes/Artwork/Components/ArtworkConsignments.tsx
@@ -48,7 +48,7 @@ export const ArtworkConsignments: React.FC<ArtworkConsignmentsProps> = ({ artwor
 
 const artworkConsignmentsFragment = graphql`
   fragment ArtworkConsignments_artwork on Artwork {
-    artists {
+    artists(shallow: true) {
       isConsignable
       name
     }
diff --git a/src/app/Scenes/Artwork/Components/ArtworkHeader.tsx b/src/app/Scenes/Artwork/Components/ArtworkHeader.tsx
@@ -141,7 +141,7 @@ export const ArtworkHeaderFragmentContainer = createFragmentContainer(ArtworkHea
       internalID
       slug
       visibilityLevel
-      artists {
+      artists(shallow: true) {
         name
       }
       partner {
diff --git a/src/app/Scenes/Artwork/Components/ArtworkLotDetails/ArtworkLotDetails.tsx b/src/app/Scenes/Artwork/Components/ArtworkLotDetails/ArtworkLotDetails.tsx
@@ -119,7 +119,7 @@ const artworkFragment = graphql`
   fragment ArtworkLotDetails_artwork on Artwork {
     isForSale
     title
-    artist {
+    artist(shallow: true) {
       name
     }
     sale {
diff --git a/src/app/Scenes/Artwork/Components/ArtworkMakerTitle.tsx b/src/app/Scenes/Artwork/Components/ArtworkMakerTitle.tsx
@@ -111,7 +111,7 @@ export const ArtworkMakerTitleFragmentContainer = createFragmentContainer(Artwor
   artwork: graphql`
     fragment ArtworkMakerTitle_artwork on Artwork {
       culturalMaker
-      artists {
+      artists(shallow: true) {
         name
         href
       }
diff --git a/src/app/Scenes/Artwork/Components/ArtworkScreenHeaderCreateAlert.tsx b/src/app/Scenes/Artwork/Components/ArtworkScreenHeaderCreateAlert.tsx
@@ -58,7 +58,7 @@ const ArtworkScreenHeaderCreateAlert_artwork = graphql`
     isEligibleToCreateAlert
     isInAuction
     ...CreateArtworkAlertModal_artwork
-    artists {
+    artists(shallow: true) {
       internalID
     }
     isForSale
diff --git a/src/app/Scenes/Artwork/Components/BrowseSimilarWorks/BrowseSimilarWorks.tsx b/src/app/Scenes/Artwork/Components/BrowseSimilarWorks/BrowseSimilarWorks.tsx
@@ -92,7 +92,7 @@ const similarWorksFragment = graphql`
     internalID
     slug
     isEligibleToCreateAlert
-    artistsArray: artists {
+    artists(shallow: true) {
       internalID
       name
     }
diff --git a/src/app/Scenes/CollectionsByCategory/CollectionRail.tsx b/src/app/Scenes/CollectionsByCategory/CollectionRail.tsx
@@ -32,12 +32,12 @@ export const CollectionRail: FC<CollectionRailProps> = ({
   const collection = useFragment(fragment, _collection)
   const { trackArtworkRailItemTap, trackArtworkRailViewAllTap } = useCollectionByCategoryTracking()
 
-  if (!collection || collection.artworksConnection?.counts.total === 0) {
+  const artworks = extractNodes(collection?.artworksConnection)
+
+  if (!collection || !artworks.length) {
     return null
   }
 
-  const artworks = extractNodes(collection.artworksConnection)
-
   const handleArtworkPress = (artwork: ArtworkRail_artworks$data[0], index: number) => {
     trackArtworkRailItemTap(artwork.internalID, index)
     navigate(artwork.href ?? "")
@@ -89,9 +89,6 @@ const fragment = graphql`
     slug @required(action: NONE)
 
     artworksConnection(first: 10, sort: "-decayed_merch") {
-      counts @required(action: NONE) {
-        total
-      }
       edges {
         node {
           ...ArtworkRail_artworks

Original file line number	Diff line number	Diff line change
`@@ -539,7 +539,7 @@ export default createFragmentContainer(Artwork, {`
`539`	`539`	`endAt`
`540`	`540`	`extendedBiddingEndAt`
`541`	`541`	`}`
`542`		`- partner {`
	`542`	`+ partner(shallow: true) {`
`543`	`543`	`name`
`544`	`544`	`}`
`545`	`545`	`image(includeAll: $includeAllImages) {`
Original file line number	Diff line number	Diff line change
@@ -272,7 +272,7 @@ const artworkMetaFragment = graphql`
`272`	`272`	`}`
`273`	`273`	`}`
`274`	`274`	`saleMessage`
`275`		`- partner {`
	`275`	`+ partner(shallow: true) {`
`276`	`276`	`name`
`277`	`277`	`}`
`278`	`278`	`title`
Original file line number	Diff line number	Diff line change
@@ -145,7 +145,7 @@ const artworkFragment = graphql`
`145`	`145`	`endAt`
`146`	`146`	`extendedBiddingEndAt`
`147`	`147`	`}`
`148`		`- partner {`
	`148`	`+ partner(shallow: true) {`
`149`	`149`	`name`
`150`	`150`	`}`
`151`	`151`	`}`
Original file line number	Diff line number	Diff line change
`@@ -732,7 +732,7 @@ export const ArtworkContainer = createRefetchContainer(`
`732`	`732`	`type`
`733`	`733`	`isInquireable`
`734`	`734`	`}`
`735`		`- artist {`
	`735`	`+ artist(shallow: true) {`
`736`	`736`	`biographyBlurb {`
`737`	`737`	`text`
`738`	`738`	`}`
`@@ -774,7 +774,7 @@ export const ArtworkContainer = createRefetchContainer(`
`774`	`774`	`}`
`775`	`775`	`}`
`776`	`776`	`}`
`777`		`- artists {`
	`777`	`+ artists(shallow: true) {`
`778`	`778`	`isConsignable`
`779`	`779`	`}`
`780`	`780`	`isEligibleForArtsyGuarantee`
Original file line number	Diff line number	Diff line change
`@@ -71,15 +71,15 @@ export const AboutArtistFragmentContainer = createFragmentContainer(AboutArtist,`
`71`	`71`	artwork: graphql`
`72`	`72`	`fragment AboutArtist_artwork on Artwork {`
`73`	`73`	`displayArtistBio`
`74`		`- artists {`
	`74`	`+ artists(shallow: true) {`
`75`	`75`	`id`
`76`	`76`	`biographyBlurb {`
`77`	`77`	`text`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`...ArtistListItem_artist`
`81`	`81`	`}`
`82`		`- artist {`
	`82`	`+ artist(shallow: true) {`
`83`	`83`	`partnerBiographyBlurb {`
`84`	`84`	`text`
`85`	`85`	`}`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ export const ArtworkConsignments: React.FC<ArtworkConsignmentsProps> = ({ artwor`
`48`	`48`
`49`	`49`	const artworkConsignmentsFragment = graphql`
`50`	`50`	`fragment ArtworkConsignments_artwork on Artwork {`
`51`		`- artists {`
	`51`	`+ artists(shallow: true) {`
`52`	`52`	`isConsignable`
`53`	`53`	`name`
`54`	`54`	`}`
Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ export const ArtworkHeaderFragmentContainer = createFragmentContainer(ArtworkHea`
`141`	`141`	`internalID`
`142`	`142`	`slug`
`143`	`143`	`visibilityLevel`
`144`		`- artists {`
	`144`	`+ artists(shallow: true) {`
`145`	`145`	`name`
`146`	`146`	`}`
`147`	`147`	`partner {`
Original file line number	Diff line number	Diff line change
@@ -119,7 +119,7 @@ const artworkFragment = graphql`
`119`	`119`	`fragment ArtworkLotDetails_artwork on Artwork {`
`120`	`120`	`isForSale`
`121`	`121`	`title`
`122`		`- artist {`
	`122`	`+ artist(shallow: true) {`
`123`	`123`	`name`
`124`	`124`	`}`
`125`	`125`	`sale {`