Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFTExtension interface conformance doesn't check anything #35

Open
caffeinum opened this issue Mar 12, 2022 · 1 comment
Open

NFTExtension interface conformance doesn't check anything #35

caffeinum opened this issue Mar 12, 2022 · 1 comment
Labels
Run AutoPR 🚀

Comments

@caffeinum
Copy link
Member

caffeinum commented Mar 12, 2022 •
edited
Loading

Given INFTExtension interface is empty, the ERC165 check for that is always true.

https://github.com/buildship-dev/nft-contracts/blob/2f33f71c05266b45b1f1e3fb80e421087dd8f5b7/contracts/factory/extensions/INFTExtension.sol#L6-L7

Which means addExtension check doesn't check anything:
https://github.com/buildship-dev/nft-contracts/blob/2f33f71c05266b45b1f1e3fb80e421087dd8f5b7/contracts/factory/MetaverseNFT.sol#L201-L205
@caffeinum caffeinum changed the title NFTExtension interface doesn't check anything NFTExtension interface conformance doesn't check anything Mar 12, 2022
@caffeinum
Copy link
Member Author

Possible solutions are:

  • including some specific field like keccak("nftfactory.nftextension")
  • including name or type view function

@github-actions github-actions bot mentioned this issue Apr 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Run AutoPR 🚀
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix NFTExtension Interface Conformance Check in MetaverseNFT artgenexyz/nft-contracts
1 participant
@caffeinum