Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom "Base64" by the JDK version #273

Closed
WolfgangHG opened this issue Dec 4, 2024 · 3 comments
Closed

Replace custom "Base64" by the JDK version #273

WolfgangHG opened this issue Dec 4, 2024 · 3 comments

Comments

@WolfgangHG
Copy link
Contributor

Class https://github.com/arquillian/arquillian-extension-warp/blob/main/impl/src/main/java/org/jboss/arquillian/warp/impl/utils/Base64.java was probably copied from some Apache project.

Base64 encoding is part of the Java framework since 1.8: https://docs.oracle.com/javase/8/docs/api/java/util/Base64.html
@WolfgangHG WolfgangHG mentioned this issue Dec 4, 2024
Merged
rhusar added a commit to rhusar/arquillian-extension-warp that referenced this issue Jan 15, 2025
@rhusar
Replace custom "Base64" by the JDK version arquillian#273
9418f01
@rhusar
Copy link
Collaborator

rhusar commented Jan 15, 2025

Opened PR - #282

rhusar added a commit that referenced this issue Jan 17, 2025
@rhusar
Merge pull request #282 from rhusar/cleanup-base64
9302920 
Replace custom "Base64" by the JDK version #273
@rhusar
Copy link
Collaborator

rhusar commented Jan 17, 2025

Done.

@rhusar rhusar closed this as completed Jan 17, 2025
@WolfgangHG
Copy link
Contributor Author

Cool, thanks!

WolfgangHG pushed a commit to WolfgangHG/arquillian-extension-warp that referenced this issue Jan 18, 2025
@rhusar @WolfgangHG
Replace custom "Base64" by the JDK version arquillian#273
2425f4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WolfgangHG @rhusar