red is possible, let's get this to green

Author: arnehormann

mirror.go

@@ -40,17 +40,14 @@ func CanConvert(from, to reflect.Type) bool {
 					return false
 				}
 			case reflect.Struct:
-				if recurseStructs <= 0 && tsf.Name() != ttf.Name() {
+				if tsf.Name() != ttf.Name() {
 					return false
 				}
 				done = true
 			default:
 				done = true
 			}
 		}
-		if recurseStructs > 0 && !CanConvert(tsf, ttf, recurseStructs-1) {
-			return false
-		}
 	}
 	return true
 }

mirror_test.go

@@ -36,7 +36,7 @@ func TestMirror(t *testing.T) {
 	}
 	for _, x := range tests {
 		ta, tb := reflect.TypeOf(x.a), reflect.TypeOf(x.b)
-		if x.ok != CanConvert(ta, tb, 0) {
+		if x.ok != CanConvert(ta, tb) {
 			if x.ok {
 				t.Errorf("%s: could convert [%v] to [%v]\n",
 					x.name, ta, tb)