-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calico.frp.SignalSuite.Signal: monad (stack-unsafe).semigroupal associativity
#101
Comments
Help wanted: can anybody reproduce this issue locally? By cloning the repo and running No matter how hard I try I cannot reproduce this locally. Even after making everything deterministic (see #118) and using the exact same seed as CI. |
Also failed to reproduce locally... |
New (related?) failure in 3f4e43b.
|
I made some progress on this. I'm pretty confident it's not a real issue in practice, but more of a testing issue. When two events happen at the exact same time, there is non-determinism in which order they get resolved. This becomes a discrepancy in the equality check. I need to think about how exactly to fix this. I still don't understand why it's so hard to reproduce, and impossible to reproduce deterministically. In theory, setting the seed for the test runtime should make these non-determinstic orderings deterministic, but that doesn't seem to be working. My best guess is that there is a bug in the test runtime? |
Here's an unminimized example of
|
I added even more debug in 8503fe7.
The
The problem is in this portion:
What is alarming is that
So if somehow the Ref updates are running concurrently, they could non-deterministically be misordered.
Now, the question is why are two Anyway, I will put up a PR shortly to fix this. The test is a bit poorly-written; instead of using a |
Oh, and there's still the CE bug (?) about the test runtime somehow being non-deterministic 🙃 |
Noooo still failing 😭 789da9c
|
now a failure in
|
https://github.com/armanbilge/calico/actions/runs/3365416652/jobs/5580859544
76cc916
The text was updated successfully, but these errors were encountered: