Address comments

Sovietaced · Sovietaced · commit 90e9d4572bf3 · 2024-11-25T20:56:25.000-08:00
Signed-off-by: Jason Parraga &lt;sovietaced@gmail.com&gt;
diff --git a/internal/controller/install/armadaserver_controller_test.go b/internal/controller/install/armadaserver_controller_test.go
@@ -433,7 +433,7 @@ func TestSchedulerReconciler_createIngress(t *testing.T) {
 
 	input := v1alpha1.ArmadaServer{
 		TypeMeta: metav1.TypeMeta{
-			Kind:       "armadaserver",
+			Kind:       "ArmadaServer",
 			APIVersion: "install.armadaproject.io/v1alpha1",
 		},
 		ObjectMeta: metav1.ObjectMeta{
diff --git a/internal/controller/install/binoculars_controller_test.go b/internal/controller/install/binoculars_controller_test.go
@@ -481,7 +481,7 @@ func TestSchedulerReconciler_createBinocularsIngress(t *testing.T) {
 
 	input := v1alpha1.Binoculars{
 		TypeMeta: metav1.TypeMeta{
-			Kind:       "binoculars",
+			Kind:       "Binoculars",
 			APIVersion: "install.armadaproject.io/v1alpha1",
 		},
 		ObjectMeta: metav1.ObjectMeta{
diff --git a/internal/controller/install/common_helpers.go b/internal/controller/install/common_helpers.go
@@ -317,7 +317,7 @@ func ExtractPulsarConfig(config runtime.RawExtension) (PulsarConfig, error) {
 	if err != nil {
 		return PulsarConfig{}, err
 	}
-	return asConfig.Pulsar, err
+	return asConfig.Pulsar, nil
 }
 
 // GetServerScheme returns the URI scheme for the grpc server

Original file line number	Diff line number	Diff line change
`@@ -317,7 +317,7 @@ func ExtractPulsarConfig(config runtime.RawExtension) (PulsarConfig, error) {`
`317`	`317`	`if err != nil {`
`318`	`318`	`return PulsarConfig{}, err`
`319`	`319`	`}`
`320`		`- return asConfig.Pulsar, err`
	`320`	`+ return asConfig.Pulsar, nil`
`321`	`321`	`}`
`322`	`322`
`323`	`323`	`// GetServerScheme returns the URI scheme for the grpc server`