Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application が独自で内部に有効化/無効化フラグをもつことがおおいが,AM で一括してもてばいいのでは? #239

Open
meltingrabbit opened this issue Dec 13, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers priority::medium priority medium

Comments

@meltingrabbit
Copy link
Member

meltingrabbit commented Dec 13, 2023

詳細

あるAppを,TL にはいってても,動かしたくないことがある.
そういうときは,Appに enble フラグを持たせて,事実上実行されないようにしている,たとえば

if (event_utility_.is_enabled_eh_execution)
{
EH_execute();
}

static RESULT APP_HOGE_update_(void)
{
  if !hoge_.is_enabled return  RESULT_OK;
  ...

など.

これ,よく見るので,AMでもってもよいのでは?

pro / con

  • Appごとに実装
    • コマンドがわかりやすい
      • Cmd_HOGE_APP_ENABLE , Cmd_HOGE_APP_DISABLE
  • AM で実装
    • すべてのAppに勝手に実装される
    • コマンドがわかりにくい
      • Cmd_AM_ENABLE_APP {app id} で app id は enum でコロコロ変わってしまう

close条件

実装したら

@meltingrabbit meltingrabbit added enhancement New feature or request good first issue Good for newcomers priority::medium priority medium labels Dec 13, 2023
@meltingrabbit
Copy link
Member Author

デバッグ用途ぐらいしか使う用途ないかもな

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers priority::medium priority medium
Projects
Status: No status
Development

No branches or pull requests

1 participant