Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation height with nested <ul> #211

Open
diplopito opened this issue Mar 27, 2017 · 2 comments
Open

Navigation height with nested <ul> #211

diplopito opened this issue Mar 27, 2017 · 2 comments

Comments

@diplopito
Copy link

When using nested

    for submenus (like ul li ul li ... /li /ul /li /ul), the _calcHeight function (629) fails to calculate the correct height. One possible solution would be to use an ID for the navigation container and iterate through the children. In the meantime setting an initial value bigger than zero for savedHeight (634) fixes the issue.

@benbennybenben
Copy link

I've tried setting the initial value of the 'savedHeight' (634) to 1 and 10 and that unfortunately hasn't fixed it. It just adds what ever value I change it to on to the small height that it calculates.

I then tried changing my nested ul and li tags to divs and that didn't fix the issue either

The weird thing is, is that the height calculation works fine on some mobile devices (my iPhone 6) but not others.

@diplopito
Copy link
Author

The value is in pixels: 1 and 10 seem to be very low values, In my case I had to use '30' to add 2 missing lines. I also tried with Iphone and without the fix it would skip lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants