Add support for custom connection string parameters in PostgreSQL connection URL

[romangai21]

Summary

Add support for custom connection string parameters in PostgreSQL connection URL for Argo Workflows, specifically to allow setting binary_parameters=yes. Currently, the connection string configuration doesn't support adding custom parameters, which causes issues when using PgBouncer with PostgreSQL for archiving and offloading workflows.

Use Cases

When would you use this?

The modification is particularly important for production environments where PgBouncer is commonly used as a standard practice for PostgreSQL connection pooling and management. Or any other custom use case people may have.

---

Message from the maintainers:

Love this feature request? Give it a 👍. We prioritise the proposals with the most 👍.

[romangai21]

Related Slack conversation: https://cloud-native.slack.com/archives/C01QW9QSSSK/p1734516501951449

[MasonM]

Thanks for the details. Here's the code that'd need to change for this:

argo-workflows/persist/sqldb/sqldb.go

Lines 59 to 74 in 7d7ebb1

	settings := postgresqladp.ConnectionURL{
	User: string(userNameByte),
	Password: string(passwordByte),
	Host: cfg.GetHostname(),
	Database: cfg.Database,
	}
	if cfg.SSL {
	if cfg.SSLMode != "" {
	options := map[string]string{
	"sslmode": cfg.SSLMode,
	}
	settings.Options = options
	}
	}

The only question is whether we allow users specify an arbitrary key-value pair of options or just add an option specifically for binary_parameters=yes. I'm leaning towards the former, since that's more future-proof and could replace the existing ssl and sslMode options.