You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
I have searched existing issues and could not find a match for this bug
The UI should reflect the true state of all Workflow steps/tasks/outputs/etc., but this is not the case with regards to DAG exit-handlers as they successfully complete execution, but still are displayed as 'Pending' on the UI:
Version(s)
v3.5.10, v3.6.0-rc4, v3.6.2
Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Example1 (using suspend step, issue triggered at stoppage any time during suspend step):
apiVersion: argoproj.io/v1alpha1kind: Workflowmetadata:
generateName: test-stop-bug-example-spec:
entrypoint: mainonExit: exit-handler # Issue occurs (using a DAG)# onExit: cleanup-step # Issue does not occur (not using a DAG)arguments:
parameters:
- name: imagevalue: "alpine:latest"
- name: durationvalue: 60templates:
- name: maindag:
tasks:
- name: suspend-dag # Manually stop this step to reproduce the bug, when using a DAG exit-handlertemplate: suspend-step
- name: exit-handlerdag:
tasks:
- name: cleanup-dagtemplate: cleanup-step
- name: suspend-stepsuspend:
duration: '{{workflow.parameters.duration}}'
- name: cleanup-stepcontainer:
image: '{{workflow.parameters.image}}'command: ['echo']args: ['Executed on-exit cleanup step']
Example2 (issue occurs when stoppage is within ~5seconds of step completion):
The Workflows are Completed (failed) and the individual steps are also Completed, too:
>>> kubectl get wf -n project-il
NAME STATUS AGE MESSAGE
test-stop-bug-example-5m944 Failed 23m Stopped with strategy 'Stop'
test-stop-bug-example2-gkbbp Failed 22m
>>> kubectl get po -n project-il
NAME READY STATUS RESTARTS AGE
test-stop-bug-example-5m944-cleanup-step-2119134400 0/2 Completed 0 23m
test-stop-bug-example2-gkbbp-cleanup-2095643750 0/2 Completed 0 22m
test-stop-bug-example2-gkbbp-sleep-2154453211 0/2 Completed 0 22m
It seems that there is an issue with the logic for judging onExitCompleted here.
In this case, onExitCompleted will always be true because the targetTask itself is part of exit-handler and its taskNode is not Fulfilled.
Pre-requisites
:latest
image tag (i.e.quay.io/argoproj/workflow-controller:latest
) and can confirm the issue still exists on:latest
. If not, I have explained why, in detail, in my description below.What happened? What did you expect to happen?
The UI should reflect the true state of all Workflow steps/tasks/outputs/etc., but this is not the case with regards to DAG exit-handlers as they successfully complete execution, but still are displayed as 'Pending' on the UI:
Version(s)
v3.5.10, v3.6.0-rc4, v3.6.2
Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Example1 (using suspend step, issue triggered at stoppage any time during suspend step):
Example2 (issue occurs when stoppage is within ~5seconds of step completion):
Logs from the workflow controller
kubectl logs -n argo deploy/argo-server
Logs from in your workflow's wait container
kubectl logs -n project-il -c wait -l workflows.argoproj.io/workflow=${workflow} [example1]:
kubectl logs -n project-il -c wait -l workflows.argoproj.io/workflow=${workflow} [example2]:
The text was updated successfully, but these errors were encountered: