Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment Notification using old rollout/pre-trigger state - related to #3535? #4021

Open
2 tasks done
Hellspam opened this issue Dec 22, 2024 · 0 comments · May be fixed by #4022
Open
2 tasks done

Experiment Notification using old rollout/pre-trigger state - related to #3535? #4021

Hellspam opened this issue Dec 22, 2024 · 0 comments · May be fixed by #4022
Labels
bug Something isn't working

Comments

@Hellspam
Copy link

Hellspam commented Dec 22, 2024

Checklist:

  • I've included steps to reproduce the bug.
  • I've included the version of argo rollouts.

Describe the bug

I've been trying to use the on-experiment- triggers to send slack notifications due to an issue that seems similar to #3535 - the experiment object in the trigger has the pre reconciliation state of the experiment, which means I cannot use it to send the error message, or analysis results.

To Reproduce

Create an experiment, and use one of the on-experiment-xxx triggers. In the trigger template, trying to use something like .rollout.status.phase (also not clear why there is only a .rollout object even though when examined you get an Experiment object).
For example, when an experiment fails, we get status Pending.

Expected behavior

I expected to be able to use the experiment object to send the slack notification to users, such as the failure message, failing analysis.
Ideally I'd also have wanted that the context would include the queries and measurements from the analysis runs.

Version

Tested in 1.7.2 in production cluster, but reproduced in 1.8.0-rc1 and master branch locally.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@Hellspam Hellspam added the bug Something isn't working label Dec 22, 2024
Hellspam added a commit to Hellspam/argo-rollouts that referenced this issue Dec 22, 2024
Hellspam added a commit to Hellspam/argo-rollouts that referenced this issue Dec 22, 2024
Hellspam added a commit to Hellspam/argo-rollouts that referenced this issue Dec 22, 2024
Hellspam added a commit to Hellspam/argo-rollouts that referenced this issue Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant