From 0e05ef766edb706b503fa3d345468471328355ba Mon Sep 17 00:00:00 2001 From: Bishal Thapa Date: Tue, 17 Sep 2024 10:34:14 +0100 Subject: [PATCH] Improve Documentation for Scaledown on Aborted Rollout MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Improves understanding of how scaling down behaves depending on different configurations. • Canary with traffic routing + setCanaryScale does not scales down immediately when `abortScaleDownDelaySeconds = 0`. • Canary with traffic routing + setCanaryScale scales down after some delay of N second `abortScaleDownDelaySeconds = N`. --- docs/features/scaledown-aborted-rs.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/features/scaledown-aborted-rs.md b/docs/features/scaledown-aborted-rs.md index 40740fce64..ed60944688 100644 --- a/docs/features/scaledown-aborted-rs.md +++ b/docs/features/scaledown-aborted-rs.md @@ -13,6 +13,8 @@ is scaled down in 30 seconds on abort by default. | blue-green | does not scale down | N | scales down after N seconds | | basic canary | rolling update back to stable | N/A | rolling update back to stable | | canary w/ traffic routing | scales down immediately | nil | scales down after 30 seconds | -| canary w/ traffic routing | scales down immediately | 0 | does not scale down | -| canary w/ traffic routing | scales down immediately | N | scales down after N seconds | +| canary w/ traffic routing | scales down immediately | 0 | scales down immediately | +| canary w/ traffic routing | scales down immediately | N | scales down immediately | +| canary w/ traffic routing + setCanaryScale | scales down immediately | 0 | does not scale down | +| canary w/ traffic routing + setCanaryScale | scales down immediately | N | scales down after N seconds | | canary w/ traffic routing + setCanaryScale | does not scale down (bug) | * | should behave like canary w/ traffic routing |