-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hera does not have AW 3.6 types (pod_gc
on WorkflowTemplate
is not rendered correctly)
#1292
Comments
I think this is a change in the API models used by Argo 3.6. We have this on our radar (#1215) so I'll take a look to confirm 👀 |
Confirmed this is a result of pod_gc=m.PodGC(
delete_delay_duration="5m",
strategy="OnWorkflowCompletion",
), |
pod_gc
on WorkflowTemplate
is not renedered correctlypod_gc
on WorkflowTemplate
is not rendered correctly
Thank you. Do you have an idea how I cloud render the pod_gc now before the new hera release? |
with WorkflowTemplate(
pod_gc=m.PodGC.construct(
delete_delay_duration="5m",
strategy="OnWorkflowCompletion",
)
) as w:
pass |
Ah, perfect. Thank you so much. |
pod_gc
on WorkflowTemplate
is not rendered correctlypod_gc
on WorkflowTemplate
is not rendered correctly)
Pre-bug-report checklist
1. This bug can be reproduced using pure Argo YAML
If yes, it is more likely to be an Argo bug unrelated to Hera. Please double check before submitting an issue to Hera.
2. I have searched for existing issues
3. This bug occurs in Hera when...
Bug report
Describe the bug
I am using
WorkflowTemplate
withpod_gc
rendering the yaml of this gives:
According to https://argo-workflows.readthedocs.io/en/latest/fields/#podgc
it should render as:
deleteDelayDuration
should be a string and not aDuration
objectTo Reproduce
Full Hera code to reproduce the bug:
Expected behavior
render
Environment
Could you please give me a hint how to fix that?
The text was updated successfully, but these errors were encountered: