Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Remove unneeded variables in input file #185

Open
yardasol opened this issue Jan 17, 2023 · 0 comments
Open

Feature: Remove unneeded variables in input file #185

yardasol opened this issue Jan 17, 2023 · 0 comments

Comments

@yardasol
Copy link
Contributor

Background and motivation

In PR #177, we add default values to many of the parameters. Some of these parameters, particularly those related to the name of the results file and the results directory, should always be their default value.

Description of idea

We should remove the following parameters from the input file and hardcode them:

  • db_name
  • output_path

Implementation details

We will need to do the following:

  1. Delete the above variables from the input schema and input files
  2. Determine where to hardcode the default values, then implement that.

Potential snags

This will break the API and be part of the full v0.5.0 release, but not the prerelease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant