Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Version for 0.4.0 release is 0.4.dev-0 #127

Closed
yardasol opened this issue Feb 15, 2022 · 2 comments
Closed

[Bug]: Version for 0.4.0 release is 0.4.dev-0 #127

yardasol opened this issue Feb 15, 2022 · 2 comments

Comments

@yardasol
Copy link
Contributor

yardasol commented Feb 15, 2022

Expected behavior

The version for the 0.4.0 release should be 0.4.0

Describe the bug

The version is actually 0.4.dev-0

To Reproduce

Steps to reproduce the behavior:

  1. Look at saltproc/version.py under the v0.4.0 tag

System Specifications:

  • Software version: SaltProv v0.4.0

How can this issue be closed?

There should be some process that either automates switching _version_extra in version.py from dev to '' before publishing a release, or enabled editing of the saltproc/version.py file once the release is published. Both would be nice.

This issue can be closed when a PR that adds the described functionality exists, AND when the version.py under the v0.4.0 tag has the correct version.

Some ideas on how to do this:

  • Make the next-minor-release.yml workflow trigger from closing a milestone, and add functionality to change version.py as well as publishing the current draft release. We will also document this in the Developer guide.
  • Implement Feature: Branched release model #116 so we can update version.py as needed after publishing a release
  • Add a workflow that makes a PR making the changes to version.py that must be merged before publishing the release
@yardasol
Copy link
Contributor Author

Also, @munkm, since the tagged release has the incorrect version, how to we fix it? Delete and re-release?

@yardasol
Copy link
Contributor Author

Closing as this is better suited to a feature request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant