Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: More detailed error messages #118

Open
8 tasks
yardasol opened this issue Feb 3, 2022 · 0 comments
Open
8 tasks

Feature: More detailed error messages #118

yardasol opened this issue Feb 3, 2022 · 0 comments

Comments

@yardasol
Copy link
Contributor

yardasol commented Feb 3, 2022

Background and motivation

There are several places in the SaltProc source code where try-except blocks are used to catch errors. In most of the except blocks a message prints instead of raising another exception.

Description of idea

Raising specific exceptions in the except blocks would give us more specific error messages. This is useful for debugging.

Implementation details

The following functions and locations in the code have try-catch blocks where no exceptions are raised:

  • app.read_main_input
  • DepcodeSerpent.create_iter_matfile
  • DepcodeSerpent.switch_to_next_geometry
  • Simulation.store_after_repr
  • Simulation.store_mat_data
  • Simulation.store_run_step_info
  • Simulation.store_run_init_info
  • Simulation.check_restart

Potential snags

This may require modifying unit/integration tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant