Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support running SaltProc from notebooks #117

Open
7 tasks
yardasol opened this issue Feb 2, 2022 · 0 comments
Open
7 tasks

Feature: Support running SaltProc from notebooks #117

yardasol opened this issue Feb 2, 2022 · 0 comments

Comments

@yardasol
Copy link
Contributor

yardasol commented Feb 2, 2022

Background and motivation

When we implement #109 and have more fleshed out examples, it would be nice to be able to have .ipynb files that users can download and run on their own machines.

Description of idea

We should add functionality in app.py to allow users to run SaltProc inside a python environment while maintaining the current capability to run from the command line.

Implementation details

SaltProc is locked into the command line in the App.parse_arguments function, as App.parse_arguments only looks for input from the command line.

I propose the following:

  • Add a new function in app.py that will handle inputs within a python context OR add control flow to the current App.parse_arguments function that will detect if we are running from the command line or from a python context.
  • Add global variables or class attributes to app.py (that will be set from either command line input or python context input) that will make accessible the following variables to the App.run function:
    • n, the number of nodes to use in parallel execution
    • d, the number of cores to use in parallel execution
    • i, the path to the SaltProc input file
    • use these variables in App.run
      Optional
  • rename app to saltproc for clarity.

Potential snags

It is unclear if/how this will effect performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant