Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-remove labels #119

Merged
merged 4 commits into from
Feb 11, 2022
Merged

Auto-remove labels #119

merged 4 commits into from
Feb 11, 2022

Conversation

yardasol
Copy link
Contributor

@yardasol yardasol commented Feb 3, 2022 •
edited

Summary of changes

This PR adds a workflow, auto-labels.yml that automatically removes Status and Priority labels when issues and PRs are closed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Required for Merging

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change is a source code change
    • I have added/modified tests to cover my changes
    • I have explained why my change does not require new/modified tests
  • All new and existing tests passed.
    • CI tests pass
    • Local tests pass (including Serpent2 integration tests)

Associated Issues and PRs

Associated Developers

Checklist for Reviewers

Reviewers should use this link to get to the
Review Checklist before they begin their review.

@yardasol yardasol added this to the Repository Improvement milestone Feb 3, 2022
@yardasol yardasol added this to In progress in Advanced Reactors via automation Feb 3, 2022
@yardasol yardasol changed the title Auto-close labels Auto-remove labels Feb 8, 2022
@yardasol yardasol marked this pull request as ready for review February 8, 2022 16:47
abachma2
abachma2 reviewed Feb 11, 2022
View reviewed changes
Copy link
Contributor

@abachma2 abachma2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty straightforward with what you are trying to accomplish. But why is this needed?

@yardasol
Copy link
Contributor Author

yardasol commented Feb 11, 2022 •
edited

This is pretty straightforward with what you are trying to accomplish. But why is this needed?

Issues and PRs that are closed probably shouldn't have a status or priority labels. For example, sometimes a label on a closed PR/issue won't get updated and will remain "in progress" or "in review" as it's status label. Instead of creating new labels for to indicate this (which is redundant, we already know they are closed), it's easier to just remove those labels.

@abachma2
Copy link
Contributor

OK. That makes sense. I will approve this then and merge it.

@abachma2 abachma2 merged commit bd4c9e4 into arfc:master Feb 11, 2022
Advanced Reactors automation moved this from In progress to Done Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abachma2 abachma2 abachma2 approved these changes

@munkm munkm Awaiting requested review from munkm

Assignees
No one assigned
Labels
Difficulty:2-Challenging Status:7-WontFix Type:Style
Projects
Advanced Reactors
  
Done
Milestone
Repository Improvement
Development

Successfully merging this pull request may close these issues.

Feature: Auto assign, change and remove labels based on context
2 participants
@yardasol @abachma2